manager: improve error messages for exec failures#2395
Merged
Conversation
Summary: This gives users a more explicit error message for common configuration errors, like virtualenvs with `--system-site-packages` that mix and match packages and binaries across environments. Test Plan: Automated tests cover changes to `manager.py`. For notebook changes, build the Pip package, and install it and `IPython` to a new virtualenv. From an IPython shell, run through all the cases: ``` In [1]: %load_ext tensorboard In [2]: import os In [3]: os.environ["PATH"] = "" In [4]: %tensorboard --logdir logs Launching TensorBoard... ERROR: Could not find `tensorboard`. Please ensure that your PATH contains an executable `tensorboard` program, or explicitly specify the path to a TensorBoard binary by setting the `TENSORBOARD_BINARY` environment variable. In [5]: os.environ["TENSORBOARD_BINARY"] = "/not/likely" In [6]: %tensorboard --logdir logs Launching TensorBoard... ERROR: Could not find '/not/likely' (set by the `TENSORBOARD_BINARY` environment variable). Please ensure that your PATH contains an executable `tensorboard` program, or explicitly specify the path to a TensorBoard binary by setting the `TENSORBOARD_BINARY` environment variable. In [7]: os.environ["TENSORBOARD_BINARY"] = "." # EACCES In [8]: %tensorboard --logdir logs Launching TensorBoard... ERROR: Failed to start '.' (set by the `TENSORBOARD_BINARY` environment variable): [Errno 13] Permission denied: '.' ``` wchargin-branch: manager-execfailed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This gives users a more explicit error message for common configuration
errors, like virtualenvs with
--system-site-packagesthat mix andmatch packages and binaries across environments.
Test Plan:
Automated tests cover changes to
manager.py. For notebook changes,build the Pip package, and install it and
IPythonto a new virtualenv.From an IPython shell, run through all the cases:
wchargin-branch: manager-execfailed