Skip to content

[TF-TRT] Various Cleanups & Python Debugging Assertion Improvements#55804

Closed
DEKHTIARJonathan wants to merge 1 commit into
tensorflow:masterfrom
DEKHTIARJonathan:tftrt/unittest_cleanup
Closed

[TF-TRT] Various Cleanups & Python Debugging Assertion Improvements#55804
DEKHTIARJonathan wants to merge 1 commit into
tensorflow:masterfrom
DEKHTIARJonathan:tftrt/unittest_cleanup

Conversation

@DEKHTIARJonathan
Copy link
Copy Markdown
Contributor

@DEKHTIARJonathan DEKHTIARJonathan commented Apr 29, 2022 •
edited by bixia1
Loading

This PR cleans a few spots in the code base, improves the debuggability of assertion messages in unittests. And replace distutils.version.LooseVersion (deprecated) with packaging.version.Version (new recommended API).

@google-ml-butler google-ml-butler Bot added the size:M CL Change Size: Medium label Apr 29, 2022
@DEKHTIARJonathan
Copy link
Copy Markdown
Contributor Author

DEKHTIARJonathan commented Apr 29, 2022

@bixia1 for review

@gbaned gbaned added the comp:gpu:tensorrt Issues specific to TensorRT label May 2, 2022
@gbaned gbaned requested a review from bixia1 May 2, 2022 08:32
@google-ml-butler google-ml-butler Bot added the awaiting review Pull request awaiting review label May 2, 2022
@DEKHTIARJonathan
Copy link
Copy Markdown
Contributor Author

DEKHTIARJonathan commented May 13, 2022

@bixia1 can you please review ?

@gbaned
Copy link
Copy Markdown
Contributor

gbaned commented Jun 1, 2022

@bixia1 Can you please review this PR ? Thank you!

bixia1
bixia1 reviewed Jun 9, 2022
View reviewed changes
Comment thread tensorflow/python/compiler/tensorrt/test/tf_trt_integration_test_base.py Outdated
Comment thread tensorflow/python/compiler/tensorrt/test/tf_trt_integration_test_base.py Outdated
Comment thread tensorflow/python/compiler/tensorrt/test/tf_trt_integration_test_base.py Outdated
Comment thread tensorflow/python/compiler/tensorrt/test/tf_trt_integration_test_base.py Outdated
Comment thread tensorflow/python/compiler/tensorrt/test/tf_trt_integration_test_base.py Outdated
Comment thread tensorflow/python/compiler/tensorrt/test/tf_trt_integration_test_base.py Outdated
Comment thread tensorflow/python/compiler/tensorrt/test/tf_trt_integration_test_base.py Outdated
Comment thread tensorflow/python/compiler/tensorrt/test/tf_trt_integration_test_base.py Outdated
Comment thread tensorflow/python/compiler/tensorrt/test/tf_trt_integration_test_base.py Outdated
Comment thread tensorflow/python/compiler/tensorrt/test/tf_trt_integration_test_base.py Outdated
@tensorflowbutler tensorflowbutler removed the awaiting review Pull request awaiting review label Jun 11, 2022
@gbaned
Copy link
Copy Markdown
Contributor

gbaned commented Jun 16, 2022

@DEKHTIARJonathan Can you please check @bixia1's comments and keep us posted ? Thank you!

@gbaned gbaned added the stat:awaiting response Status - Awaiting response from author label Jul 1, 2022
@gbaned
Copy link
Copy Markdown
Contributor

gbaned commented Jul 8, 2022

Hi @DEKHTIARJonathan Any update on this PR? Please. Thank you!

2 similar comments
@gbaned
Copy link
Copy Markdown
Contributor

gbaned commented Jul 19, 2022

Hi @DEKHTIARJonathan Any update on this PR? Please. Thank you!

@gbaned
Copy link
Copy Markdown
Contributor

gbaned commented Aug 5, 2022

Hi @DEKHTIARJonathan Any update on this PR? Please. Thank you!

@DEKHTIARJonathan
Copy link
Copy Markdown
Contributor Author

DEKHTIARJonathan commented Aug 10, 2022

@bixia1 all comments have been addressed, please review:

INFO: Build completed successfully, 105 total actions
//tensorflow/python/compiler/tensorrt:trt_convert_test_gpu               PASSED in 166.5s
//tensorflow/python/compiler/tensorrt/test:batch_matmul_test_gpu         PASSED in 97.4s
//tensorflow/python/compiler/tensorrt/test:biasadd_matmul_test_gpu       PASSED in 188.5s
//tensorflow/python/compiler/tensorrt/test:binary_tensor_weight_broadcast_test_gpu PASSED in 234.3s
//tensorflow/python/compiler/tensorrt/test:cast_test_gpu                 PASSED in 33.7s
//tensorflow/python/compiler/tensorrt/test:concatenation_test_gpu        PASSED in 77.6s
//tensorflow/python/compiler/tensorrt/test:const_broadcast_test_gpu      PASSED in 108.1s
//tensorflow/python/compiler/tensorrt/test:dynamic_input_shapes_test_gpu PASSED in 98.6s
//tensorflow/python/compiler/tensorrt/test:identity_output_test_gpu      PASSED in 23.9s
//tensorflow/python/compiler/tensorrt/test:int32_test_gpu                PASSED in 13.4s
//tensorflow/python/compiler/tensorrt/test:lru_cache_test_gpu            PASSED in 30.8s
//tensorflow/python/compiler/tensorrt/test:memory_alignment_test_gpu     PASSED in 34.2s
//tensorflow/python/compiler/tensorrt/test:multi_connection_neighbor_engine_test_gpu PASSED in 121.8s
//tensorflow/python/compiler/tensorrt/test:neighboring_engine_test_gpu   PASSED in 28.7s
//tensorflow/python/compiler/tensorrt/test:quantization_test_gpu         PASSED in 42.3s
//tensorflow/python/compiler/tensorrt/test:rank_two_test_gpu             PASSED in 166.7s
//tensorflow/python/compiler/tensorrt/test:reshape_transpose_test_gpu    PASSED in 5.8s
//tensorflow/python/compiler/tensorrt/test:topk_test_gpu                 PASSED in 30.5s
//tensorflow/python/compiler/tensorrt/test:trt_engine_op_shape_test_gpu  PASSED in 55.7s
//tensorflow/python/compiler/tensorrt/test:trt_mode_test_gpu             PASSED in 106.5s
//tensorflow/python/compiler/tensorrt/test:unary_test_gpu                PASSED in 325.8s
//tensorflow/python/compiler/tensorrt/test:vgg_block_nchw_test_gpu       PASSED in 31.6s
//tensorflow/python/compiler/tensorrt/test:vgg_block_test_gpu            PASSED in 118.5s

Executed 23 out of 23 tests: 23 tests pass.
INFO: Build completed successfully, 105 total actions

@google-ml-butler google-ml-butler Bot removed the stat:awaiting response Status - Awaiting response from author label Aug 10, 2022
bixia1
bixia1 reviewed Aug 11, 2022
View reviewed changes
Comment thread tensorflow/python/compiler/tensorrt/test/tf_trt_integration_test_base.py Outdated
@DEKHTIARJonathan
Copy link
Copy Markdown
Contributor Author

DEKHTIARJonathan commented Aug 12, 2022

@bixia1 comments addressed. Please review

@google-ml-butler google-ml-butler Bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Aug 12, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Aug 12, 2022
@google-ml-butler google-ml-butler Bot removed the ready to pull PR ready for merge process label Aug 13, 2022
@sachinprasadhs sachinprasadhs mentioned this pull request Oct 19, 2022
Closed
trevor-m pushed a commit to trevor-m/tensorflow that referenced this pull request Oct 20, 2022
@nluehr
[TF-TRT] Various Cleanups & Python Debugging Assertion Improvements -…
6506d14 
… PR tensorflow#55804
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bixia1 bixia1 bixia1 approved these changes

Assignees

@gbaned gbaned

Labels

comp:gpu:tensorrt Issues specific to TensorRT size:M CL Change Size: Medium

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@DEKHTIARJonathan @gbaned @bixia1 @mihaimaruseac @kokoro-team @tensorflowbutler