Skip to content

fix: explicitly mark arg as nullable#103

Merged
dkaser merged 1 commit into
trunkfrom
fix/deprecated-construct
Mar 20, 2026
Merged

fix: explicitly mark arg as nullable#103
dkaser merged 1 commit into
trunkfrom
fix/deprecated-construct

Conversation

@dkaser
Copy link
Copy Markdown
Collaborator

@dkaser dkaser commented Mar 20, 2026 •
edited by coderabbitai Bot
Loading

Summary by CodeRabbit

  • Refactor
    • Improved code type safety with updated parameter declarations.

Note: This release contains internal code improvements with no user-facing changes or new functionality.

@dkaser dkaser merged commit f1c8e58 into trunk Mar 20, 2026
4 of 5 checks passed
@github-actions github-actions Bot added the fix label Mar 20, 2026
@dkaser dkaser deleted the fix/deprecated-construct branch March 20, 2026 02:09
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 20, 2026 •
edited
Loading

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 1b649760-2234-482d-bd42-470252669baf

📥 Commits

Reviewing files that changed from the base of the PR and between e1b3dbf and 2039324.

📒 Files selected for processing (1)
  • src/usr/local/php/unraid-tailscale-utils/unraid-tailscale-utils/ServeConfig.php

Disabled knowledge base sources:

  • Linear integration is disabled

You can enable these sources in your CodeRabbit configuration.

📝 Walkthrough

Walkthrough

Updated the constructor parameter type declaration for ServeConfig from non-nullable \stdClass to nullable ?\stdClass, aligning the type hint with the existing default null value. Runtime behavior unchanged.

Changes

Cohort / File(s) Summary
Type Declaration Update
src/usr/local/php/unraid-tailscale-utils/unraid-tailscale-utils/ServeConfig.php		 Constructor parameter type hint changed from \stdClass $config = null to ?\stdClass $config = null to properly declare nullable type matching the default value.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/deprecated-construct
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can approve the review once all CodeRabbit's comments are resolved.

Enable the reviews.request_changes_workflow setting to automatically approve the review once all CodeRabbit's comments are resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@dkaser