Skip to content

[None][infra] Pin the version of mypy due to dependency conflicts#12650

Merged
EmmaQiaoCh merged 2 commits into
NVIDIA:mainfrom
EmmaQiaoCh:pin-mypy-version
Apr 1, 2026
Merged

[None][infra] Pin the version of mypy due to dependency conflicts#12650
EmmaQiaoCh merged 2 commits into
NVIDIA:mainfrom
EmmaQiaoCh:pin-mypy-version

Conversation

@EmmaQiaoCh
Copy link
Copy Markdown
Collaborator

@EmmaQiaoCh EmmaQiaoCh commented Apr 1, 2026 •
edited by coderabbitai Bot
Loading

Summary by CodeRabbit

  • Chores
    • Updated development environment tooling dependencies to ensure consistent build configurations and improved stability across development workflows.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

@EmmaQiaoCh EmmaQiaoCh requested a review from a team as a code owner April 1, 2026 05:35
@EmmaQiaoCh
Copy link
Copy Markdown
Collaborator Author

EmmaQiaoCh commented Apr 1, 2026

/bot run --stage-list "B200_PCIe-PackageSanityCheck-PY312-DLFW, RTX5090-PackageSanityCheck-PY312-UB2404"

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 1, 2026

📝 Walkthrough

Walkthrough

Updated the mypy development dependency in requirements-dev.txt from an unpinned version to a constrained version below 1.20.0, affecting dependency resolution for local development environments.

Changes

Cohort / File(s) Summary
Development Dependencies
requirements-dev.txt		 Updated mypy version constraint from unpinned (mypy) to mypy<1.20.0, constraining the resolver to versions below 1.20.0.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description contains only the template structure with no actual implementation details, explanation of the issue, test coverage, or substantive content beyond the template. Add detailed explanation of the dependency conflict, why mypy<1.20.0 was chosen, and what test coverage validates this change.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The pull request title clearly describes the main change: pinning mypy version due to dependency conflicts, which aligns with the actual modification to requirements-dev.txt.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]
coderabbitai Bot reviewed Apr 1, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
requirements-dev.txt (1)

4-4: mypy<1.20.0 is a range constraint, not a strict pin (Line 4).

The PR objective states "Pin the version of mypy due to dependency conflicts," but <1.20.0 allows version drift within the range. If the intent is deterministic dependency management to avoid conflicts, use an exact pin like mypy==1.19.0 and document the chosen version.

Suggested change 
-mypy<1.20.0
+mypy==1.19.0
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@requirements-dev.txt` at line 4, The dev requirements currently use a range
constraint "mypy<1.20.0" which allows version drift; replace that with a strict
pin such as "mypy==1.19.0" in requirements-dev.txt (or the exact version you
choose) and add a short comment in the file explaining why this specific mypy
version was pinned to avoid dependency conflicts.
🤖 Prompt for all review comments with AI agents 
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@requirements-dev.txt`:
- Line 4: The dev requirements currently use a range constraint "mypy<1.20.0"
which allows version drift; replace that with a strict pin such as
"mypy==1.19.0" in requirements-dev.txt (or the exact version you choose) and add
a short comment in the file explaining why this specific mypy version was pinned
to avoid dependency conflicts.
ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 90e3ae7b-666f-4535-9a44-ef7742bdf606

📥 Commits

Reviewing files that changed from the base of the PR and between a696ecb and 3c41b0d.

📒 Files selected for processing (1)
  • requirements-dev.txt

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

tensorrt-cicd commented Apr 1, 2026

PR_Github #41117 [ run ] triggered by Bot. Commit: 3c41b0d Link to invocation

@EmmaQiaoCh
Copy link
Copy Markdown
Collaborator Author

EmmaQiaoCh commented Apr 1, 2026

/bot run --stage-list "B200_PCIe-PackageSanityCheck-PY312-DLFW, RTX5090-PackageSanityCheck-PY312-UB2404"

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

tensorrt-cicd commented Apr 1, 2026

PR_Github #41122 [ run ] triggered by Bot. Commit: 0768949 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

tensorrt-cicd commented Apr 1, 2026

PR_Github #41117 [ run ] completed with state ABORTED. Commit: 3c41b0d

Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

tensorrt-cicd commented Apr 1, 2026

PR_Github #41122 [ run ] completed with state SUCCESS. Commit: 0768949
/LLM/main/L0_MergeRequest_PR pipeline #32093 (Partly Tested) completed with status: 'SUCCESS'

CI Report

Link to invocation

@EmmaQiaoCh EmmaQiaoCh merged commit 1e51f1c into NVIDIA:main Apr 1, 2026
4 of 5 checks passed
@bmarimuthu-nv bmarimuthu-nv mentioned this pull request Apr 2, 2026
Closed
1 task
karen-sy pushed a commit to karen-sy/TensorRT-LLM that referenced this pull request Apr 7, 2026
@EmmaQiaoCh @karen-sy
[None][infra] Pin the version of mypy due to dependency conflicts (NV…
d6abace 
…IDIA#12650)

Signed-off-by: qqiao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@ZhanruiSunCh ZhanruiSunCh ZhanruiSunCh approved these changes

Assignees

@EmmaQiaoCh EmmaQiaoCh

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@EmmaQiaoCh @tensorrt-cicd @ZhanruiSunCh