Skip to content

[None][chore] Fix indexing conflict in blogposts#13772

Merged
brb-nv merged 1 commit into
NVIDIA:mainfrom
brb-nv:user/brb/fix-blog-naming-conflict
May 5, 2026
Merged

[None][chore] Fix indexing conflict in blogposts#13772
brb-nv merged 1 commit into
NVIDIA:mainfrom
brb-nv:user/brb/fix-blog-naming-conflict

Conversation

@brb-nv
Copy link
Copy Markdown
Collaborator

@brb-nv brb-nv commented May 5, 2026 •
edited by coderabbitai Bot
Loading

Description

There were competing MRs adding blogposts indexed at 21. This MR bumps the one that merged later to 22.

Test Coverage

N/A

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Summary by CodeRabbit

  • Documentation
    • Refreshed blog post with updated figures including roofline analysis, execution flow diagrams, attention sharding comparisons, and performance plots.

@brb-nv brb-nv requested a review from a team as a code owner May 5, 2026 18:23
@brb-nv brb-nv requested review from kaiyux and laikhtewari May 5, 2026 18:23
@brb-nv brb-nv requested a review from chang-l May 5, 2026 18:24
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 5, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: f8383891-4921-432e-8306-a4843426b087

📥 Commits

Reviewing files that changed from the base of the PR and between 2da7a97 and ac86923.

⛔ Files ignored due to path filters (4)
  • docs/source/blogs/media/tech_blog22_attention_sharding.png is excluded by !**/*.png
  • docs/source/blogs/media/tech_blog22_dsr1_fp4_pareto.png is excluded by !**/*.png
  • docs/source/blogs/media/tech_blog22_helix_execution_flow.png is excluded by !**/*.png
  • docs/source/blogs/media/tech_blog22_roofline_analysis.png is excluded by !**/*.png
📒 Files selected for processing (1)
  • docs/source/blogs/tech_blog/blog22_Helix_Parallelism_Scaling_Multi_Million_Token_Decoding_with_KV_Cache_Sharding.md
📝 Walkthrough

Walkthrough

This PR updates image file references in a technical blog post from version 21 to version 22 assets. Four blog figure images (roofline analysis, Helix execution flow, attention sharding, and DeepSeek-R1 Pareto plot) are renumbered. No text or explanations are changed.

Changes

Blog Asset References Update

Layer / File(s) Summary
Image References
docs/source/blogs/tech_blog/blog22_Helix_Parallelism_Scaling_Multi_Million_Token_Decoding_with_KV_Cache_Sharding.md		 Image filenames updated from tech_blog21_* to tech_blog22_* for roofline analysis, Helix execution flow, attention sharding, and DeepSeek-R1 Pareto figures.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: fixing an indexing conflict in blogposts by renaming blog22-related files.
Description check ✅ Passed The description explains the issue (competing blogposts indexed at 21) and the solution (bumping to index 22) but lacks detailed explanation of what was changed and why.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@brb-nv
Copy link
Copy Markdown
Collaborator Author

brb-nv commented May 5, 2026

/bot skip --comment "docs update only"

@brb-nv brb-nv removed request for kaiyux and laikhtewari May 5, 2026 18:27
@brb-nv brb-nv enabled auto-merge (squash) May 5, 2026 18:29
@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

tensorrt-cicd commented May 5, 2026

PR_Github #46850 [ skip ] triggered by Bot. Commit: ac86923 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

tensorrt-cicd commented May 5, 2026

PR_Github #46850 [ skip ] completed with state SUCCESS. Commit: ac86923
Skipping testing for commit ac86923

Link to invocation

@brb-nv brb-nv merged commit 5deb230 into NVIDIA:main May 5, 2026
10 checks passed
yufeiwu-nv pushed a commit to yufeiwu-nv/TensorRT-LLM that referenced this pull request May 19, 2026
@brb-nv @yufeiwu-nv
[None][chore] Fix indexing conflict in blogposts (NVIDIA#13772)
a263d64 
Signed-off-by: Balaram Buddharaju <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chang-l chang-l chang-l approved these changes

Assignees

@brb-nv brb-nv

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@brb-nv @tensorrt-cicd @chang-l