Skip to content

[None][chore] gitignore NFS system temporary files#14211

Merged
zhenhuaw-me merged 1 commit into
NVIDIA:mainfrom
zhenhuaw-me:ignore-nfs
May 18, 2026
Merged

[None][chore] gitignore NFS system temporary files#14211
zhenhuaw-me merged 1 commit into
NVIDIA:mainfrom
zhenhuaw-me:ignore-nfs

Conversation

@zhenhuaw-me
Copy link
Copy Markdown
Member

@zhenhuaw-me zhenhuaw-me commented May 17, 2026 •
edited by coderabbitai Bot
Loading

Summary by CodeRabbit

  • Chores
    • Updated git configuration to exclude .nfs* files.

Review Change Stack

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 17, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: ff08f8df-1f44-41ea-9add-45b3c051d06e

📥 Commits

Reviewing files that changed from the base of the PR and between 65a5b34 and c46b24c.

📒 Files selected for processing (1)
  • .gitignore
📝 Walkthrough

Walkthrough

This PR adds a single ignore pattern to .gitignore to exclude NFS-generated cache files (.nfs*) from version control. The change is a straightforward configuration update with no impact on source code or behavior.

Changes

NFS cache pattern exclusion

Layer / File(s) Summary
NFS cache pattern exclusion
.gitignore		 Added .nfs* ignore pattern to exclude NFS cache artifacts from version control.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~1 minute

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is incomplete; it only contains the template with guidance text and no actual description, test coverage, or filled-out PR checklist details. Fill in the 'Description' and 'Test Coverage' sections with details about why NFS files should be ignored and what testing was done to verify the change.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The PR title clearly describes the main change: adding a .gitignore rule to exclude NFS temporary files, which matches the actual changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@zhenhuaw-me
Copy link
Copy Markdown
Member Author

zhenhuaw-me commented May 18, 2026

/bot skip --comment "git ignore update only"

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

tensorrt-cicd commented May 18, 2026

PR_Github #48843 [ skip ] triggered by Bot. Commit: c46b24c Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

tensorrt-cicd commented May 18, 2026

PR_Github #48843 [ skip ] completed with state SUCCESS. Commit: c46b24c
Skipping testing for commit c46b24c

Link to invocation

@zhenhuaw-me zhenhuaw-me merged commit 2ad0060 into NVIDIA:main May 18, 2026
13 of 14 checks passed
@zhenhuaw-me zhenhuaw-me deleted the ignore-nfs branch May 18, 2026 06:25
KleinBlueC pushed a commit to KleinBlueC/TensorRT-LLM that referenced this pull request May 19, 2026
@zhenhuaw-me
[None][chore] gitignore NFS system temporary files (NVIDIA#14211)
bbc2b0d 
Signed-off-by: Zhenhua Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kaiyux kaiyux kaiyux approved these changes

Assignees

@zhenhuaw-me zhenhuaw-me

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zhenhuaw-me @tensorrt-cicd @kaiyux