Fix XSS in rendered report: HTML-escape user-controlled reportLanguage#3337
Merged
baev merged 1 commit intoMay 11, 2026
Merged
Conversation
baev
approved these changes
May 11, 2026
Member
|
@grootstebozewolf please rebase |
Sister to the reportName escaping fix. reportLanguage is set via
ConfigurationBuilder#withReportLanguage and interpolated into the
lang attribute on the root <html> tag in index.html.ftl. Without
escaping, a value like
en"><script>alert('xss')</script>
breaks out of the attribute and injects live markup. Apply
per-variable HTML escaping at the bug site:
<html dir="ltr" lang="${(reportLanguage!"en")?html}">
Adds ReportWebGeneratorTest#shouldEscapeHtmlInReportLanguage, which
fails on main and passes with this change. Existing
shouldSetLanguage / shouldSetDefaultLanguageIfNotProvided tests
continue to pass — escaping a value with no HTML metacharacters is
a no-op.
Co-Authored-By: Claude Opus 4.7 <[email protected]>
f870ecc to
3788196
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Sister to #3334.
reportLanguageis set viaConfigurationBuilder#withReportLanguageand interpolated into thelangattribute on the root<html>tag inindex.html.ftl. With no auto-escaping configured on the FreeMarker context, a value likebreaks out of the attribute and injects live markup. Apply per-variable HTML escaping at the bug site:
Existing
shouldSetLanguageandshouldSetDefaultLanguageIfNotProvidedtests continue to pass — escaping a value with no HTML metacharacters is a no-op.Checklist