Add Table Functions to FFI Crate#15581
Merged
Merged
Conversation
ca6cf45 to
7681029
Compare
alamb
approved these changes
Apr 7, 2025
Contributor
alamb
left a comment
There was a problem hiding this comment.
Looks good to me -- thank you @timsaucer
|
|
||
| /// This test validates nullary input UDFs | ||
| #[tokio::test] | ||
| async fn test_nullary_scalar_udf() -> Result<()> { |
Contributor
There was a problem hiding this comment.
A test for nullary udfs seems out of place with tests for user defined table functions -- is this maybe a copy/paste error?
Contributor
There was a problem hiding this comment.
Do you want to handle this comment on this PR @timsaucer or shall we merge the PR and handle it later?
Member
Author
There was a problem hiding this comment.
Sorry, should be good to go now.
Contributor
|
Merged up from main to get a clean CI run (hopefully) |
Member
Author
|
I’ll resolve those clippy warnings next time I’m at my computer |
Contributor
|
Very exciting -- thanks @timsaucer |
nirnayroy
pushed a commit
to nirnayroy/datafusion
that referenced
this pull request
May 2, 2025
* Initial commit adding user defined table functions to FFI crate * Minor format change * Remove duplicate test * Remove unused imports --------- Co-authored-by: Andrew Lamb <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This addresses part of #14562
Rationale for this change
We currently have support for user defined scalar functions. Aggregates and Windows are underway. This PR adds user defined table functions.
What changes are included in this PR?
Are these changes tested?
Yes, tests added to the PR.
Are there any user-facing changes?
None, but additional APIs are now available.