Skip to content

fix(cli): show sync wait dependencies#25369

Merged
f0ssel merged 1 commit into
release/2.32from
matifali/backport-25089-release-2.32
May 18, 2026
Merged

fix(cli): show sync wait dependencies#25369
f0ssel merged 1 commit into
release/2.32from
matifali/backport-25089-release-2.32

Conversation

@matifali
Copy link
Copy Markdown
Member

Summary

Backports #25089 to release/2.32 so coder exp sync want and coder exp sync start print the dependency units involved in startup coordination instead of generic success messages.

Validation

  • git diff --check origin/release/2.32..HEAD
  • go test ./cli -run TestSyncCommands -count=1

Note

make test RUN=TestSyncCommands hit an unrelated codersdk/toolsdk filtered-test failure because that package expects all tools to be tested. The affected CLI test passed with the package-scoped command above.

🤖 This PR was created with the help of Coder Agents, and needs a human review. 🧑💻

## Problem
`coder exp sync want` and `coder exp sync start` both printed generic
success messages, which hid the dependency units involved in startup
coordination.

Before, declaring dependencies with `sync want` printed:

```text
Success
```

Before, `sync start` printed while waiting, then finished with another
generic success message:

```text
Waiting for dependencies of unit 'test-unit' to be satisfied...
Success
```

## Solution
Print the dependency units in both cases, using wording that matches
where the command is in the lifecycle.

After, `sync want` prints the dependencies it declared for the unit:

```text
Unit "test-unit" declared dependencies: [dep-unit]
```

After, `sync start` enumerates the dependencies while it is waiting,
then prints the same dependencies after the unit starts executing:

```text
Unit "test-unit" is waiting for dependencies to be satisfied: [dep-unit, dep-unit-2]
Unit "test-unit" finished waiting for dependencies: [dep-unit, dep-unit-2]
```

The sync golden tests now cover the updated output, including multiple
dependencies for `sync start`.

(cherry picked from commit f3e90b3)
@matifali matifali marked this pull request as ready for review May 14, 2026 20:39
@matifali matifali requested a review from f0ssel May 14, 2026 20:39
@f0ssel f0ssel merged commit 882689a into release/2.32 May 18, 2026
39 of 40 checks passed
@f0ssel f0ssel deleted the matifali/backport-25089-release-2.32 branch May 18, 2026 12:55
@github-actions github-actions Bot locked and limited conversation to collaborators May 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants