fix: clean up port-reserver.pid and the parent dir when the container…#4811
Merged
AkihiroSuda merged 1 commit intoMar 30, 2026
Merged
Conversation
… is removed In the current implementation, when a container is started with the -p option, a `sleep infinity` process is launched to reserve host ports. The PID of this process is stored in `/run/nerdctl/<namespace>/<container ID>/port-reserver.pid`. When the container is removed, the following file and directory are expected to be cleaned up. - /run/nerdctl/<namespace>/<container ID>/port-reserver.pid - /run/nerdctl/<namespace>/<container ID>/ However, currently they are not removed as shown below: ``` $ sudo nerdctl run -d --name nginx -p 81:80 nginx ca1552d394cd8efcc5adcff9434deb4f3ead569d168f6e31bea1ae965db8b919 $ ls /run/nerdctl/default/ca1552d394cd8efcc5adcff9434deb4f3ead569d168f6e31bea1ae965db8b919 port-reserver.pid $ sudo nerdctl rm -f nginx nginx $ ls /run/nerdctl/default/ca1552d394cd8efcc5adcff9434deb4f3ead569d168f6e31bea1ae965db8b919 port-reserver.pid ``` Therefore, this commit ensures that they are removed when the container is removed. Signed-off-by: Hayato Kiwata <[email protected]>
haytok
added a commit
to haytok/nerdctl
that referenced
this pull request
Apr 2, 2026
…tworkSettings follow-up: containerd#4811 Signed-off-by: Hayato Kiwata <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… is removed
In the current implementation, when a container is started with the
-poption, asleep infinityprocess is launched to reserve host ports.The PID of this process is stored in
/run/nerdctl/<namespace>/<container ID>/port-reserver.pid.When the container is removed, the following file and directory are expected to be cleaned up.
/run/nerdctl/<namespace>/<container ID>/port-reserver.pid/run/nerdctl/<namespace>/<container ID>/However, currently they are not removed as shown below:
Therefore, this commit ensures that they are removed when the container is removed.