Integration test for batch. Fixes #874. by mderka · Pull Request #919 · googleapis/google-cloud-java

mderka · 2016-04-13T21:00:54Z

The test performs the same operations as the integration test without batch. Where possible, it groups calls into a single batch call. It adds one test checking that a combination of operations is possible as well.

Sign in to view

+      batch.submit();
+      zones = filter(result.get().iterateAll());
+      assertEquals(2, zones.size());
+      assertTrue(zones.contains(created));


ajkannan · 2016-04-14T00:45:59Z

Done with my pass.

mderka · 2016-04-14T02:32:39Z

Ready to proceed.

coveralls · 2016-04-14T02:37:13Z

Coverage remained the same at 85.22% when pulling b50ad15 on mderka:ittestbatch into beea588 on GoogleCloudPlatform:dns-alpha-batch.

Sign in to view

-        assertTrue(Iterators.contains(iteratorList, iteratorBatch.next()));
+      zones = filter(result.get().iterateAll());
+      assertEquals(firstZone, zones.get(0));
+      assertEquals(1, zones.size());


mderka · 2016-04-14T19:12:12Z

PTAL

coveralls · 2016-04-14T19:17:01Z

Coverage decreased (-0.002%) to 85.218% when pulling aade170 on mderka:ittestbatch into beea588 on GoogleCloudPlatform:dns-alpha-batch.

Sign in to view

 import com.google.cloud.dns.Zone;
 import com.google.cloud.dns.ZoneInfo;
 import com.google.common.collect.ImmutableList;
+import com.google.common.collect.Iterables;


coveralls · 2016-04-14T19:49:35Z

Coverage increased (+0.009%) to 85.228% when pulling 66c257d on mderka:ittestbatch into beea588 on GoogleCloudPlatform:dns-alpha-batch.

mderka · 2016-04-14T19:52:23Z

PTAL

mziccard · 2016-04-14T20:21:19Z

Looks good to me. @ajkannan do you have any further comments? If not feel free to merge after squashing the commits.

mderka · 2016-04-14T21:46:17Z

Fixes #874.

coveralls · 2016-04-15T00:24:19Z

Coverage decreased (-0.002%) to 85.218% when pulling 6e9ed8c on mderka:ittestbatch into beea588 on GoogleCloudPlatform:dns-alpha-batch.

mderka · 2016-04-15T00:25:57Z

Fixed everywhere.

ajkannan · 2016-04-15T00:32:00Z

LGTM

* Integration test for batch. Fixes googleapis#874. * Adjusted batch calls in integration tests. * Removed unnecessary copying. * Removed unused import. * Replaced change IDs equals tests with not null.

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [io.grpc:grpc-bom](https://togithub.com/grpc/grpc-java) | `1.49.0` -> `1.49.1` | [![age](https://badges.renovateapi.com/packages/maven/io.grpc:grpc-bom/1.49.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/io.grpc:grpc-bom/1.49.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/io.grpc:grpc-bom/1.49.1/compatibility-slim/1.49.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/io.grpc:grpc-bom/1.49.1/confidence-slim/1.49.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>grpc/grpc-java</summary> ### [`v1.49.1`](https://togithub.com/grpc/grpc-java/compare/v1.49.0...v1.49.1) [Compare Source](https://togithub.com/grpc/grpc-java/compare/v1.49.0...v1.49.1) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-core).

🤖 I have created a release *beep* *boop* --- ## [2.8.13](googleapis/java-core@v2.8.12...v2.8.13) (2022-09-20) ### Dependencies * Update dependency io.grpc:grpc-bom to v1.49.1 ([#919](googleapis/java-core#919)) ([82b611f](googleapis/java-core@82b611f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…en-plugin to v1.6.12 (#919)

…logback to v0.129.0-alpha (#919) * chore(deps): update dependency com.google.cloud:google-cloud-logging-logback to v0.129.0-alpha * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Co-authored-by: Anthonios Partheniou <[email protected]> Source-Link: googleapis/synthtool@9457e69 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:a3fe0b4c75f322520f548e535ed329df1e475ace3cb4a979b78e003cb822636a Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <[email protected]>

…en-plugin to v1.6.12 (googleapis#919)

…o v1-rev20220604-1.32.1 (#919)

🤖 I have created a release *beep* *boop* --- ## [0.124.3](googleapis/java-storage-nio@v0.124.2...v0.124.3) (2022-06-08) ### Dependencies * update dependency com.google.apis:google-api-services-storage to v1-rev20220604-1.32.1 ([#919](googleapis/java-storage-nio#919)) ([a3b650a](googleapis/java-storage-nio@a3b650a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…o v1-rev20220604-1.32.1 (#919)

🤖 I have created a release *beep* *boop* --- ## [0.124.3](googleapis/java-storage-nio@v0.124.2...v0.124.3) (2022-06-08) ### Dependencies * update dependency com.google.apis:google-api-services-storage to v1-rev20220604-1.32.1 ([#919](googleapis/java-storage-nio#919)) ([a3b650a](googleapis/java-storage-nio@a3b650a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Integration test for batch. Fixes googleapis#874.

74c9bc1

mderka added the api: dns Issues related to the Cloud DNS API. label Apr 13, 2016

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 13, 2016

ajkannan reviewed Apr 13, 2016
View reviewed changes

Adjusted batch calls in integration tests.

b50ad15

mziccard reviewed Apr 14, 2016
View reviewed changes

Removed unnecessary copying.

aade170

mziccard reviewed Apr 14, 2016
View reviewed changes

Removed unused import.

66c257d

Replaced change IDs equals tests with not null.

6e9ed8c

ajkannan merged commit 8ec2027 into googleapis:dns-alpha-batch Apr 15, 2016

aozarov mentioned this pull request Apr 15, 2016

Implement integration tests for DNS batch #874

Closed

suztomo pushed a commit that referenced this pull request Feb 1, 2023

deps: update dependency io.grpc:grpc-bom to v1.51.0 (#919)

46a0371

meltsufin pushed a commit that referenced this pull request Dec 22, 2025

build(deps): update dependency org.sonatype.plugins:nexus-staging-mav…

f5851af

…en-plugin to v1.6.12 (#919)

suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 11, 2026

build(deps): update dependency org.sonatype.plugins:nexus-staging-mav…

8825d46

…en-plugin to v1.6.12 (googleapis#919)

suztomo pushed a commit that referenced this pull request Mar 30, 2026

deps: update dependency com.google.apis:google-api-services-storage t…

a3b650a

…o v1-rev20220604-1.32.1 (#919)

lqiu96 pushed a commit that referenced this pull request Apr 1, 2026

deps: update dependency com.google.apis:google-api-services-storage t…

6268b0c

…o v1-rev20220604-1.32.1 (#919)

Conversation

mderka commented Apr 13, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

ajkannan commented Apr 14, 2016

Uh oh!

mderka commented Apr 14, 2016

Uh oh!

coveralls commented Apr 14, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

mderka commented Apr 14, 2016

Uh oh!

coveralls commented Apr 14, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

coveralls commented Apr 14, 2016

Uh oh!

mderka commented Apr 14, 2016

Uh oh!

mziccard commented Apr 14, 2016

Uh oh!

mderka commented Apr 14, 2016

Uh oh!

coveralls commented Apr 15, 2016

Uh oh!

mderka commented Apr 15, 2016

Uh oh!

ajkannan commented Apr 15, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants