Skip to content

Remove Python 3.7 (EOL since EOL since 2023-06-27) from CI#1440

Merged
firaskafri merged 3 commits into
mainfrom
python3.7-eol
Aug 4, 2023
Merged

Remove Python 3.7 (EOL since EOL since 2023-06-27) from CI#1440
firaskafri merged 3 commits into
mainfrom
python3.7-eol

Conversation

@kiendang
Copy link
Copy Markdown
Contributor

@kiendang kiendang commented Aug 3, 2023

sjdemartini
sjdemartini approved these changes Aug 3, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@sjdemartini sjdemartini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, LGTM!

One comment: we may want to change the pre-commit pyupgrade arg to use --py38-plus now instead of py37:

graphene-django/.pre-commit-config.yaml

Line 22 in 8540a93

args: [--py37-plus]

That could presumably be a separate PR after this, since we'll likely want to re-run it on all existing files to upgrade any syntax that was kept around in support of 3.7.

@kiendang
Copy link
Copy Markdown
Contributor Author

kiendang commented Aug 3, 2023

Good catch! We could also take this opportunity to switch to ruff? Ruff implements both pyupgrade and flake8 which we use in our pre-commit.

@sjdemartini
Copy link
Copy Markdown
Collaborator

sjdemartini commented Aug 3, 2023

Yeah great suggestion. I'm using ruff instead of pyupgrade, flake8, etc in a project of mine, and I'm a big fan!

@kiendang
Copy link
Copy Markdown
Contributor Author

kiendang commented Aug 4, 2023

@sjdemartini I just include the change to --py38-plus here since after running pre-commit there's no change.
I was looking into changing to ruff but it's a bit more involved since we need to migrate the flake8 and isort config in setup.cfg so will leave to a future PR.

@firaskafri firaskafri self-requested a review August 4, 2023 08:15
@firaskafri firaskafri merged commit 5eb5fe2 into main Aug 4, 2023
@firaskafri firaskafri deleted the python3.7-eol branch August 4, 2023 08:15
superlevure pushed a commit to loft-orbital/graphene-django that referenced this pull request Aug 9, 2023
@kiendang @superlevure
Remove Python 3.7 (EOL since EOL since 2023-06-27) from CI (graphql-p…
ddda456 
…ython#1440)

* Remove Python 3.7 (EOL since EOL since 2023-06-27) from CI

* Remove unused context

* Use pyupgrade --py38-plus in pre-commit
superlevure pushed a commit to loft-orbital/graphene-django that referenced this pull request Aug 10, 2023
@kiendang @superlevure
Remove Python 3.7 (EOL since EOL since 2023-06-27) from CI (graphql-p…
bef85ad 
…ython#1440)

* Remove Python 3.7 (EOL since EOL since 2023-06-27) from CI

* Remove unused context

* Use pyupgrade --py38-plus in pre-commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sjdemartini sjdemartini sjdemartini approved these changes

@firaskafri firaskafri firaskafri approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kiendang @sjdemartini @firaskafri