chore: apply fixes for UP ruff rule#5133
Merged
Merged
Conversation
Signed-off-by: emdneto <[email protected]>
Signed-off-by: emdneto <[email protected]>
Contributor
|
nice. couple failed CI checks but otherwise LGTM |
DylanRussell
approved these changes
Apr 22, 2026
Signed-off-by: emdneto <[email protected]>
MikeGoldsmith
approved these changes
Apr 24, 2026
Member
MikeGoldsmith
left a comment
There was a problem hiding this comment.
Looks good. Some linter checks failed that will need to be cleaned up.
Signed-off-by: emdneto <[email protected]>
…n into up-ruff-rule
Signed-off-by: emdneto <[email protected]>
Signed-off-by: emdneto <[email protected]>
Signed-off-by: emdneto <[email protected]>
Contributor
|
If you have time I think we could do the same thing in the contrib repo: https://github.com/open-telemetry/opentelemetry-python-contrib/blob/main/pyproject.toml#L162 |
Member
Author
That's the plan after getting this merged |
xrmx
approved these changes
May 7, 2026
Member
Author
|
Answering the question from today's SIG: I wrote this PoC: //lib_sdk.py //downstream.py And later: cc @xrmx |
raajheshkannaa
added a commit
to raajheshkannaa/opentelemetry-python
that referenced
this pull request
May 8, 2026
Submodule .rst files were removed in open-telemetry#5133. This was missed during the prior merge. Reviewed-by: Leighton Chen
raajheshkannaa
added a commit
to raajheshkannaa/opentelemetry-python
that referenced
this pull request
May 17, 2026
Submodule .rst files were removed in open-telemetry#5133. This was missed during the prior merge. Reviewed-by: Leighton Chen
herin049
pushed a commit
to herin049/opentelemetry-python
that referenced
this pull request
May 20, 2026
…ry#5017) * docs: add missing modules to sphinx documentation build Add RST files and toctree entries for modules that were not included in the sphinx doc build: API: - opentelemetry._events (Events API) - opentelemetry.attributes (Attributes utilities) - opentelemetry.trace.propagation (Trace context propagation) SDK: - opentelemetry.sdk._events (Events SDK implementation) - opentelemetry.sdk._logs.export (Log export processors and exporters) Closes open-telemetry#2573 Signed-off-by: Raajhesh Kannaa Chidambaram <[email protected]> * fix: add Event class to nitpick_ignore for sphinx docs build Signed-off-by: Raajhesh Kannaa Chidambaram <[email protected]> * fix: add changelog entry and nitpick_ignore for get_finished_logs Add CHANGELOG entry for the docs PR and suppress the Sphinx cross-reference warning for get_finished_logs (referenced as :func: in a docstring we did not modify). * fix: add Token class to nitpick_ignore for sphinx docs build * address review: remove events API, fix get_finished_logs xref, move changelog - Remove docs/api/_events.rst and docs/sdk/_events.rst (events API is deprecated per MikeGoldsmith, avoid exposing it in docs). - Remove _events entries from api/index.rst and sdk/index.rst toctrees. - Drop Event class nitpick_ignore entry (no longer needed). - Fix docstring cross-reference on InMemoryLogRecordExporter from :func: to :meth: since get_finished_logs is a method, and drop its nitpick_ignore entry. - Move changelog entry from 1.41.0/0.62b0 to Unreleased. * docs: remove trace.propagation.rst per maintainer review Submodule .rst files were removed in open-telemetry#5133. This was missed during the prior merge. Reviewed-by: Leighton Chen * docs: re-export AnyValue from attributes module for sphinx forward-ref resolution sphinx_autodoc_typehints calls get_type_hints on BoundedAttributes, which uses _ExtendedAttributes (Mapping[str, 'AnyValue']) from util.types. The forward ref to 'AnyValue' resolves in BoundedAttributes' __globals__ (the attributes module), not in util.types where it is defined. Re-export AnyValue into the attributes module namespace so the forward ref resolves and the docs build succeeds. Signed-off-by: Raajhesh Kannaa Chidambaram <[email protected]> * docs: use explicit re-export for AnyValue (fix ruff) Signed-off-by: Raajhesh Kannaa Chidambaram <[email protected]> * docs: use __all__ for AnyValue re-export to satisfy both pylint and ruff * docs: inject AnyValue into attributes namespace via conf.py instead of re-exporting Signed-off-by: Raajhesh Kannaa Chidambaram <[email protected]> * docs: migrate changelog entry to towncrier fragment Address @emdneto's feedback: replace direct CHANGELOG.md edit with a .changelog/5017.fixed fragment per the new towncrier workflow added in * docs: drop dead trace toctree (no trace.{status,span,propagation}.rst exist) The Submodules toctree referenced files that were never added in this PR and trace.propagation.rst was removed earlier per review. Sphinx -W treats the missing toctree target as a warning-as-error, breaking the docs build. Signed-off-by: Raajhesh Kannaa Chidambaram <[email protected]> --------- Signed-off-by: Raajhesh Kannaa Chidambaram <[email protected]> Co-authored-by: Raajhesh Kannaa Chidambaram <[email protected]> Co-authored-by: Leighton Chen <[email protected]> Co-authored-by: Emídio Neto <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
99% of the changes were made by ruff with
ruff check --fix. The agent removed the unused imports and fixed minor issues.Fixes #4227
This is important to make our codebase updated with the most recent supported syntax.
Assisted-by: Copilot