Change access modifier to package private for RoutingDsl.{Route,RouteParam}#13003
Merged
Merged
Conversation
…Param} - fixes illegal access prohibited since Scala 3.3.5 LTS and 3.6
Member
|
@Mergifyio backport 3.0.x 2.9.x |
Contributor
✅ Backports have been createdDetails
|
mergify Bot
added a commit
that referenced
this pull request
Dec 4, 2024
[2.9.x] Change access modifier to package private for `RoutingDsl.{Route,RouteParam}` (backport #13003) by @WojciechMazur
mergify Bot
added a commit
that referenced
this pull request
Dec 4, 2024
[3.0.x] Change access modifier to package private for `RoutingDsl.{Route,RouteParam}` (backport #13003) by @WojciechMazur
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
static privatemodifier for these 2 classes was incorrect. In the previous versions of Scala it compiled due to existence of a bug in the compiler.The mentioned bug was minimized and discussed in scala/scala3#21599 and was discovered after merging a fix scala/scala3#21362
Problem was discovered by Scala 3 Open Community Build in:
playframework/playframework- build logsplayframework/omnidoc- build logsPull Request Checklist