[2.9.x] Fix apiMappings#13085
Merged
Merged
Conversation
prop "sun.boot.class.path" does not exist anymore since at least Java 11. This code was doing nothing.
mkurz
commented
Jan 24, 2025
|
|
||
| val ScalaLibraryRegex = """^.*[/\\]scala-library-([\d\.]+)\.jar$""".r | ||
| val JavaxInjectRegex = """^.*[/\\]java.inject-([\d\.]+)\.jar$""".r | ||
| val JavaxInjectRegex = """^.*[/\\]javax.inject-([\d\.]+)\.jar$""".r |
Member
Author
There was a problem hiding this comment.
Good (find jar files):
find ~/.cache/coursier/ -type f -name '*javax.inject-*.jar'
Bad (does not find jar files):
find ~/.cache/coursier/ -type f -name '*java.inject-*.jar'
or within sbt run
show apiMappings
you will see the difference.
mkurz
commented
Jan 24, 2025
| case None => Map.empty | ||
| case Some(rtJar) => Map(file(rtJar) -> url(Docs.javaApiUrl)) | ||
| } | ||
| }, |
Member
Author
There was a problem hiding this comment.
Definitely not needed anymore, does not apply to Java 11 and newer anymore:
Java 8:
$ scala
Welcome to Scala 2.13.16 (OpenJDK 64-Bit Server VM, Java 1.8.0_432).
Type in expressions for evaluation. Or try :help.
scala> sys.props.get("sun.boot.class.path")
val res0: Option[String] = Some(/home/mkurz/.sdkman/candidates/java/8.0.432-tem/jre/lib/resources.jar:/home/mkurz/.sdkman/candidates/java/8.0.432-tem/jre/lib/rt.jar:/home/mkurz/.sdkman/candidates/java/8.0.432-tem/jre/lib/sunrsasign.jar:/home/mkurz/.sdkman/candidates/java/8.0.432-tem/jre/lib/jsse.jar:/home/mkurz/.sdkman/candidates/java/8.0.432-tem/jre/lib/jce.jar:/home/mkurz/.sdkman/candidates/java/8.0.432-tem/jre/lib/charsets.jar:/home/mkurz/.sdkman/candidates/java/8.0.432-tem/jre/lib/jfr.jar:/home/mkurz/.sdkman/candidates/java/8.0.432-tem/jre/classes:/home/mkurz/.sdkman/candidates/scala/2.13.16/lib/java-diff-utils-4.15.jar:/home/mkurz/.sdkman/candidates/scala/2.13.16/lib/jline-3.27.1.jar:/home/mkurz/.sdkman/candidates/scala/2.13.16/lib/scala-compiler.jar:/home...
vs.
Java 11 (and newer):
$ scala
Welcome to Scala 2.13.16 (OpenJDK 64-Bit Server VM, Java 11.0.25).
Type in expressions for evaluation. Or try :help.
scala> sys.props.get("sun.boot.class.path")
val res0: Option[String] = None
Member
Author
There was a problem hiding this comment.
Member
Author
|
@Mergifyio backport 3.0.x |
Contributor
✅ Backports have been createdDetails
|
Member
Author
|
@Mergifyio backport main |
Contributor
✅ Backports have been createdDetails
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
apiMappingsare incorrect #11788