Skip to content

bpo-34576 - Fix the formatting for security considerations in http.server.rst#10005

Merged
orsenthil merged 2 commits into
python:masterfrom
orsenthil:issue34576
Oct 20, 2018
Merged

bpo-34576 - Fix the formatting for security considerations in http.server.rst#10005
orsenthil merged 2 commits into
python:masterfrom
orsenthil:issue34576

Conversation

@orsenthil
Copy link
Copy Markdown
Member

@orsenthil orsenthil commented Oct 20, 2018 •
edited by bedevere-bot
Loading 

[bpo-34576](https://bugs.python.org/issue34576) - Fix the formatting for security considerations in http.server.rst

https://bugs.python.org/issue34576

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting merge labels Oct 20, 2018
@orsenthil
Copy link
Copy Markdown
Member Author

orsenthil commented Oct 20, 2018

After the fix the rendered page will look like this - https://screenshots.firefox.com/9Wlq9v1Y7M4DZBsG/localhost

@matrixise
Copy link
Copy Markdown
Member

matrixise commented Oct 20, 2018 •
edited
Loading

@orsenthil could you re-open your PR? travis will re-execute the tests for the documentation.

@orsenthil orsenthil closed this Oct 20, 2018
@orsenthil orsenthil reopened this Oct 20, 2018
@orsenthil orsenthil requested a review from vstinner October 20, 2018 16:00
ned-deily
ned-deily reviewed Oct 20, 2018
View reviewed changes
Comment thread Doc/library/http.server.rst Outdated
Copy link
Copy Markdown
Member

@ned-deily ned-deily Oct 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest using :mod: on http.server.

Copy link
Copy Markdown
Member Author

@orsenthil orsenthil Oct 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed. thanks.

@orsenthil orsenthil merged commit eeab510 into python:master Oct 20, 2018
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Oct 20, 2018

@orsenthil: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Oct 20, 2018

Thanks @orsenthil for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Oct 20, 2018

Sorry, @orsenthil, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker eeab510bb7e51802c18b3770cbb23ae0ca91da6b 3.6

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Oct 20, 2018

Thanks @orsenthil for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Oct 20, 2018

Sorry, @orsenthil, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker eeab510bb7e51802c18b3770cbb23ae0ca91da6b 3.7

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Oct 20, 2018

Thanks @orsenthil for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7.
🐍🍒⛏🤖

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Oct 20, 2018

Sorry, @orsenthil, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker eeab510bb7e51802c18b3770cbb23ae0ca91da6b 2.7

orsenthil added a commit that referenced this pull request Oct 26, 2018
@orsenthil
bpo-34576 - Fix the formatting for security considerations in http.se…
7b29782 
…rver.rst (#10005)

(cherry picked from commit eeab510)
orsenthil added a commit that referenced this pull request Oct 26, 2018
@orsenthil
[3.6] bpo-34576 - Fix the formatting for security considerations in h…
ff2aa02 
…ttp.server.rst (GH-10005)

* bpo-34576 - Fix the formatting for security considerations in http.server.rst

* Address review comment..
(cherry picked from commit eeab510)

Co-authored-by: Senthil Kumaran <[email protected]>
orsenthil added a commit that referenced this pull request Oct 26, 2018
@orsenthil
bpo-34576 - Fix the formatting for security considerations in http.se…
b5924c9 
…rver.rst (#10005)

(cherry picked from commit eeab510)
orsenthil added a commit that referenced this pull request Oct 26, 2018
@orsenthil
[3.7] bpo-34576 - Fix the formatting for security considerations in h…
16546b6 
…ttp.server.rst (GH-10005)

* bpo-34576 - Fix the formatting for security considerations in http.server.rst

* Address review comment..
(cherry picked from commit eeab510)

Co-authored-by: Senthil Kumaran <[email protected]>
orsenthil added a commit that referenced this pull request Oct 26, 2018
@orsenthil
bpo-34576 - Fix the formatting for security considerations in http.se…
859ac71 
…rver.rst (#10005)

(cherry picked from commit eeab510)
orsenthil added a commit that referenced this pull request Oct 26, 2018
@orsenthil
[2.7] bpo-34576 - Fix the formatting for security considerations in h…
084eb70 
…ttp.server.rst (GH-10005)

* bpo-34576 - Fix the formatting for security considerations in http.server.rst

* Address review comment..
(cherry picked from commit eeab510)

Co-authored-by: Senthil Kumaran <[email protected]>
orsenthil added a commit that referenced this pull request Oct 26, 2018
@orsenthil
[2.7] bpo-34576 : Backport eeab510 2.7 (#10115)
971089f 
* bpo-34576 - Fix the formatting for security considerations in http.server.rst (#10005)

* Address review comment..
(cherry picked from commit eeab510)

Co-authored-by: Senthil Kumaran <[email protected]>
orsenthil added a commit that referenced this pull request Oct 26, 2018
@orsenthil
[3.7] bpo-34576 : Backport eeab510 (#10114)
bb1876a 
* bpo-34576 - Fix the formatting for security considerations in http.server.rst (#10005)

(cherry picked from commit eeab510)
orsenthil added a commit that referenced this pull request Oct 26, 2018
@orsenthil
[3.6] - bpo-34576 : Backport eeab510 3.6 (GH-10113)
8be1c04 
* bpo-34576 - Fix the formatting for security considerations in http.server.rst (GH-10005)

(cherry picked from commit eeab510)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ned-deily ned-deily ned-deily approved these changes

@vstinner vstinner Awaiting requested review from vstinner

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@orsenthil @matrixise @bedevere-bot @miss-islington @ned-deily @serhiy-storchaka @the-knights-who-say-ni