bpo-35031, test_asycio: disable TLS 1.3 in test_start_tls_server_1()#14148
Conversation
|
test_asyncio restarted to fail on Windows buildbots after the commit f0749da backported to 3.7 and 3.8 branches: This PR doesn't really make the situation way worse: we use this workaround since October 2018. If someone can have a look at the root issue, it would be great, but in the meanwhile, we need the CI to be green again (and reliable). |
asvetlov
left a comment
There was a problem hiding this comment.
If it can fix buildbots -- I'm ok with suppressing the test
Well, this PR doesn't remove the test, it only works around a failure on 2 platforms: only test TLS 1.2 on Windows and FreeBSD. I heard that asyncio and ssl have issues on TLS 1.3 which handles TLS shutdown differently, but it seems like nobody has time to work on this issue. |
|
Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
|
GH-14150 is a backport of this pull request to the 3.8 branch. |
…ythonGH-14148) bpo-35031, bpo-35998: Reintroduce workaround on Windows and FreeBSD in test_start_tls_server_1() of test_asyncio: disable TLS v1.3 on the client context. (cherry picked from commit c034b78) Co-authored-by: Victor Stinner <[email protected]>
|
GH-14151 is a backport of this pull request to the 3.7 branch. |
…H-14148) bpo-35031, bpo-35998: Reintroduce workaround on Windows and FreeBSD in test_start_tls_server_1() of test_asyncio: disable TLS v1.3 on the client context. (cherry picked from commit c034b78) Co-authored-by: Victor Stinner <[email protected]>
…H-14148) bpo-35031, bpo-35998: Reintroduce workaround on Windows and FreeBSD in test_start_tls_server_1() of test_asyncio: disable TLS v1.3 on the client context. (cherry picked from commit c034b78) Co-authored-by: Victor Stinner <[email protected]>
…ythonGH-14148) bpo-35031, bpo-35998: Reintroduce workaround on Windows and FreeBSD in test_start_tls_server_1() of test_asyncio: disable TLS v1.3 on the client context.
…ythonGH-14148) bpo-35031, bpo-35998: Reintroduce workaround on Windows and FreeBSD in test_start_tls_server_1() of test_asyncio: disable TLS v1.3 on the client context.
Reintroduce workaround on Windows and FreeBSD in
test_start_tls_server_1() of test_asyncio: disable TLS v1.3 on the
client context.
https://bugs.python.org/issue35031