Skip to content

gh-91372: add mtime to gzip.open#32310

Merged
serhiy-storchaka merged 16 commits into
python:mainfrom
ellaellela:add-mtime-to-gzip-open
May 22, 2026
Merged

gh-91372: add mtime to gzip.open#32310
serhiy-storchaka merged 16 commits into
python:mainfrom
ellaellela:add-mtime-to-gzip-open

Conversation

@ellaellela
Copy link
Copy Markdown
Contributor

@ellaellela ellaellela commented Apr 4, 2022 •
edited by bedevere-app Bot
Loading

@AlexWaygood AlexWaygood added the type-feature A feature request or enhancement label Apr 4, 2022
MaxwellDupre
MaxwellDupre approved these changes Apr 23, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@MaxwellDupre MaxwellDupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran 64 tests in 1.929s
OK (skipped=1)
Looks ok.

@carlbordum
Copy link
Copy Markdown
Contributor

carlbordum commented May 11, 2022

Also looks good to me^

@ellaellela ellaellela mannequin mentioned this pull request Apr 10, 2022
Closed
serhiy-storchaka
serhiy-storchaka requested changes Feb 23, 2024
View reviewed changes
Comment thread Lib/test/test_gzip.py Outdated
Comment thread Lib/gzip.py Outdated
@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented Feb 23, 2024

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@AlexWaygood AlexWaygood changed the title bpo-47216: add mtime to gzip.open gh-91372: add mtime to gzip.open Feb 23, 2024
@ellaellela
Copy link
Copy Markdown
Contributor Author

ellaellela commented Mar 30, 2024

I have made the requested changes; please review again

@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented Mar 30, 2024

Thanks for making the requested changes!

@serhiy-storchaka: please review the changes made to this pull request.

@bedevere-app bedevere-app Bot requested a review from serhiy-storchaka March 30, 2024 11:08
@python-cla-bot
Copy link
Copy Markdown

python-cla-bot Bot commented Apr 18, 2025 •
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 10, 2026

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 10, 2026
@serhiy-storchaka
Copy link
Copy Markdown
Member

serhiy-storchaka commented May 20, 2026

@ellaellela, can you please sign the CLA? Otherwise we will be forced to reject this PR.

@serhiy-storchaka serhiy-storchaka added the pending The issue will be closed if no feedback is provided label May 20, 2026
@github-actions github-actions Bot removed the stale Stale PR or inactive for long period of time. label May 20, 2026
@ellaellela
Copy link
Copy Markdown
Contributor Author

ellaellela commented May 22, 2026

@serhiy-storchaka: signed it. Thx. I will rebase the PR to the newest main now. Should I remove changes from Doc/whatsnew/3.13.rst to Doc/whatsnew/3.16.rst regarding the changes to the library?

@read-the-docs-community
Copy link
Copy Markdown

read-the-docs-community Bot commented May 22, 2026 •
edited
Loading

Documentation build overview

📚 cpython-previews | 🛠️ Build #32808846 | 📁 Comparing 962e598 against main (f159419)

  🔍 Preview build  

3 files changed
± library/gzip.html
± whatsnew/3.16.html
± whatsnew/changelog.html

@ellaellela ellaellela requested a review from AA-Turner as a code owner May 22, 2026 07:20
serhiy-storchaka
serhiy-storchaka reviewed May 22, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few suggestions on formatting and documentation.

Comment thread Doc/whatsnew/3.16.rst Outdated
Comment thread Lib/gzip.py Outdated
Comment thread Misc/NEWS.d/next/Library/2022-04-04-17-58-05.bpo-47216.gPyPte.rst Outdated
Comment thread Doc/library/gzip.rst
serhiy-storchaka
serhiy-storchaka reviewed May 22, 2026
View reviewed changes
Comment thread Doc/library/gzip.rst Outdated
Comment thread Doc/library/gzip.rst Outdated
serhiy-storchaka
serhiy-storchaka approved these changes May 22, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@serhiy-storchaka serhiy-storchaka merged commit cf5c8c5 into python:main May 22, 2026
55 of 56 checks passed
@serhiy-storchaka
Copy link
Copy Markdown
Member

serhiy-storchaka commented May 22, 2026

Thank you for your contribution @ellaellela.

@ellaellela ellaellela deleted the add-mtime-to-gzip-open branch May 22, 2026 12:38
@ellaellela
Copy link
Copy Markdown
Contributor Author

ellaellela commented May 22, 2026

Anytime :)

grantlouisherman pushed a commit to grantlouisherman/cpython that referenced this pull request May 22, 2026
@ellaellela @grantlouisherman
pythongh-91372: Add mtime to gzip.open() (pythonGH-32310)
344f35d
grantlouisherman pushed a commit to grantlouisherman/cpython that referenced this pull request May 22, 2026
@ellaellela @grantlouisherman
pythongh-91372: Add mtime to gzip.open() (pythonGH-32310)
808ea13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

+1 more reviewer

@MaxwellDupre MaxwellDupre MaxwellDupre approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pending The issue will be closed if no feedback is provided type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@ellaellela @carlbordum @serhiy-storchaka @MaxwellDupre @the-knights-who-say-ni @ezio-melotti @bedevere-bot @AlexWaygood