Skip to content

docs: typo fixes#1

Merged
sokra merged 1 commit into
webpack:masterfrom
shama:doc-typos
May 1, 2012
Merged

docs: typo fixes#1
sokra merged 1 commit into
webpack:masterfrom
shama:doc-typos

Conversation

@shama
Copy link
Copy Markdown
Contributor

@shama shama commented May 1, 2012

This project is badass :D

sokra added a commit that referenced this pull request May 1, 2012
@sokra sokra merged commit dc64e3f into webpack:master May 1, 2012
@sokra
Copy link
Copy Markdown
Member

sokra commented May 1, 2012

Thanks :)

@dashed dashed mentioned this pull request Jan 9, 2014
sarendipitee added a commit to sarendipitee/webpack that referenced this pull request Mar 25, 2015
@hellatan hellatan mentioned this pull request Mar 29, 2016
@aldendaniels aldendaniels mentioned this pull request Jul 6, 2016
sokra pushed a commit that referenced this pull request Apr 27, 2018
sokra pushed a commit that referenced this pull request Mar 25, 2019
Add fix for normal Function Expression and fix code style for fix #8874
@qiaozikl
Copy link
Copy Markdown

Package.json Dependencies Comparison: v5.0.0 vs v4.0.0

Major Changes in Dependencies

Added Dependencies (v5.0.0):

  • @types/eslint-scope: "^3.7.0"
  • @types/estree: "^0.0.45"
  • @webassemblyjs/ast: "1.9.0"
  • @webassemblyjs/helper-module-context: "1.9.0"
  • @webassemblyjs/wasm-edit: "1.9.0"
  • @webassemblyjs/wasm-parser: "1.9.0"
  • browserslist: "^4.14.3"
  • enhanced-resolve: "^5.2.0" (was "^4.0.0")
  • events: "^3.2.0"
  • glob-to-regexp: "^0.4.1"
  • graceful-fs: "^4.2.4"
  • json-parse-better-errors: "^1.0.2"
  • loader-runner: "^4.1.0" (was "^2.3.0")
  • mime-types: "^2.1.27"
  • neo-async: "^2.6.2" (was "^2.5.0")
  • pkg-dir: "^4.2.0"
  • schema-utils: "^3.0.0" (was "^0.4.2")
  • tapable: "^2.0.0" (was "^1.0.0")
  • terser-webpack-plugin: "^4.1.0"
  • watchpack: "^2.0.0" (was "^1.4.0")
  • webpack-sources: "^2.0.1" (was "^1.0.1")

Removed Dependencies (v5.0.0):

  • acorn-dynamic-import: "^3.0.0"
  • ajv: "^6.1.0"
  • ajv-keywords: "^3.1.0"
  • memory-fs: "~0.4.1"
  • micromatch: "^3.1.8"
  • mkdirp: "~0.5.0"
  • node-libs-browser: "^2.0.0"
  • uglifyjs-webpack-plugin: "^1.1.1"
  • vm-browserify: "~0.0.0"

Key Changes Summary:

  1. Major version upgrades for several core dependencies
  2. WebAssembly support added with @webassemblyjs packages
  3. Schema utils upgraded from v0.4.2 to v3.0.0
  4. Tapable upgraded from v1.0.0 to v2.0.0
  5. Loader runner upgraded from v2.3.0 to v4.1.0
  6. Watchpack upgraded from v1.4.0 to v2.0.0
  7. Webpack sources upgraded from v1.0.1 to v2.0.1
  8. Terser webpack plugin added as a dependency
  9. Events library added
  10. Graceful-fs added
  11. JSON parsing improved with json-parse-better-errors

Breaking Changes:

  • Removed acorn-dynamic-import - dynamic imports are now handled differently
  • Removed ajv and ajv-keywords - schema validation approach changed
  • Removed memory-fs - file system handling changed
  • Removed node-libs-browser - browser polyfills handled differently
  • Removed uglifyjs-webpack-plugin - minification now handled by terser-webpack-plugin

This major version upgrade represents significant architectural changes in Webpack 5, particularly around WebAssembly support, improved performance, and modernized dependency handling.

teee32 added a commit to teee32/webpack that referenced this pull request Mar 23, 2026
nit webpack#2: eliminate __webpack_external_value__ hardcoded temp var
- Use the module-level localVariable directly instead of a shared temp
- Each external gets its own unique __WEBPACK_EXTERNAL_MODULE_${id}__ var
- Improves naming collision safety when multiple externals share the same scope

nit webpack#1: replace flaky setTimeout in test with deterministic polling
- Add waitForLazyChunk() that polls output directory every 50ms for .chunk. files
- Won't flake on slow CI runners

Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
xiaoxiaojx added a commit that referenced this pull request Mar 28, 2026
…erences

Split initial chunks into two categories: non-entry initial chunks
(e.g. shared split chunks) and entry chunks. Hash them in 4 phases:

1. Async chunks
2. Non-entry initial chunks (shared, vendor, etc.)
3. Runtime chunks (can now read current hashes of #1 and #2)
4. Entry chunks (can now read runtimeChunk.hash)

This ensures all hash dependencies flow in one direction
(async/initial → runtime → entry) with no circular dependencies.

Previously, runtime chunks were hashed before initial chunks, causing
GetChunkFilenameRuntimeModule to read stale cached contentHash values
in watch mode, leading to RealContentHashPlugin errors.

Fixes #20710

Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
alexander-akait added a commit that referenced this pull request May 12, 2026
Implements postcss-modules-local-by-default (PCSL) v4.2.0 pure-mode
semantics in webpack's built-in CSS modules parser:

- Every selector must contain at least one local class or id, otherwise
  the rule errors at build. Available on `css/module` and `css/auto`
  parser options; not exposed for `css/global` since pure mode is the
  opposite of the global-by-default semantic of that type.
- `/* cssmodules-pure-ignore */` directly before a rule suppresses
  that rule's check (per-rule only; does NOT propagate to nested rules).
- `/* cssmodules-pure-no-check */` placed among the leading comments
  of the file (before any rule or at-rule) disables the check for the
  whole file.
- Nested rules inside a local-bearing ancestor are treated as pure-
  compliant; `&` resolves to the parent rule's overall purity.
- `@keyframes` / `@counter-style` body contents are exempt; the at-rule
  itself still errors when its identifier is `:global(...)`.
- Rules whose body contains only nested rules don't trigger the check
  (children carry it instead, matching PCSL's `isNodeWithoutDeclarations`).
- At-rules' preludes (e.g. `min-width` inside `@media (...)`) aren't
  mistaken for declarations.

Addresses Copilot review feedback on PR #20946:
- #1: `ancestorHadLocal` now derives from "this rule is fully pure"
  (no impure comma-segment) rather than "last selector had a local",
  so `:global(.a), .b { span { ... } }` correctly throws on `span`.
- #2: `currentRulePreludeStart` now advances on top-level `;` and on
  at-rules that consume their own `;` (e.g. `@import`), so a later
  impure rule's reported selector doesn't include the preceding text.
- #3: `seenTopLevelRule` is set on any non-comment top-level node
  (including `;`-terminated at-rules), matching PCSL's
  `isPureCheckDisabled` leading-comments rule.
- #4: All pure-mode bookkeeping (stack push/pop, `currentSelectorHasLocal`
  writes, etc.) is gated behind `pureMode`, so CSS modules without
  `parser.pure` pay no overhead.

Test coverage: dedicated `test/configCases/css/pure-parser-options/`
plus the existing `postcss-modules-plugins` PCSL fixture enabled with
`parser: { pure: true }` and a full `errors.js` (43 expected throws).

https://claude.ai/code/session_014jWnrU38fbFtCwKGtnnBig
alexander-akait added a commit that referenced this pull request May 20, 2026
- Fix tsc lint failure: cast the inlined `HTML_ENTITIES` to
  `Readonly<Record<string, string>>` so the two `HTML_ENTITIES[name]`
  call sites type-check (the frozen-literal type was too narrow).

- Copilot #1: replace the `tempBuffer` string in
  `STATE_SCRIPT_DATA_DOUBLE_ESCAPE_START` / `_END` with a small
  `scriptMatch` counter against the literal `"script"`. Worst-case
  inputs with very long ASCII-alpha runs after `</` no longer grow a
  buffer or do quadratic string concatenation. Vestigial
  `tempBuffer = ""` resets in the four content-mode less-than-sign
  states (which never read the buffer) are removed; the
  `tempBuffer` variable is gone.

- Copilot #2: introduce a `MAX_ENTITY_NAME_LEN = 32` constant
  (longest WHATWG entity name including the trailing `;`) and cap
  the named-character-reference alphanumeric run at
  `MAX_ENTITY_NAME_LEN - 1`. Replaces the off-by-one
  `if (runLen > 32) break` with a clearer in-loop bound.

- Copilot #3: cap the `decodeHtmlEntities` longest-prefix backtrack
  at `MAX_ENTITY_NAME_LEN`. Inputs like `&` followed by thousands
  of alphanumerics stay linear-time; anything past the cap is
  appended verbatim.

Adds a regression test that decodes `&` + 1000 chars to confirm the
decoder doesn't go quadratic.

236/236 tests pass, 100% coverage on `walkHtmlTokens.js`,
`yarn lint` (including tsc) clean.

https://claude.ai/code/session_01N4rd8xuv5oRaHWFL8dFpwh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants